Allow different WebRTC branches to be built #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows different branches of WebRTC to be built.
Main differences with implementation in 730b7fd:
WEBRTC_BRANCH_HEAD
now only require the branch number e.g.58
WebRTC is now cloned during the main
configure
rather than in thedownload
/configure
steps of thewebrtc-src
external project. This allows to find out which branch is being built when building with the-DWEBRTC_REVISION
option.LIBWEBRTC_VERSION
is now suffixed with+${WEBRTC_BRANCH_HEAD}-${WEBRTC_REVISION}
e.g.1.0.0-9-g13f0747+60-6294a7eb71c891e9ea41273a7a94113f6802d0da
Part of the code is now conditional on
${WEBRTC_BRANCH_HEAD}
valueKnown issues (which are not regressions):
_ZN3rtc6Thread7SetNameERKSsPKv
inmain.o
and as_ZN3rtc6Thread7SetNameERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEEPKv
inlibwebrtc.a
(seems likelibstdc++
vslibc++
)Some builds are visible here (branches 57 to 61):
https://travis-ci.org/mayeut/libwebrtc/builds/266494102
https://ci.appveyor.com/project/mayeut/libwebrtc/build/1.0.21